Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
from typing import Callable
from typing import Callable, Any, Dict, Tuple, Hashable


def cache(func: Callable) -> Callable:
# Write your code here
pass
cache_store: Dict[Callable, Dict[Tuple[Hashable, ...], Any]] = {}

def wrapper(*args, **kwargs) -> Any:
if func not in cache_store:
cache_store[func] = {}
key = (args, frozenset(kwargs.items()))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using frozenset to store keyword arguments in the cache key can lead to issues when the order of keyword arguments is different but the values are the same. Consider using a sorted tuple of items instead: tuple(sorted(kwargs.items())).

if key in cache_store[func]:
print("Getting from cache")
return cache_store[func][key]

print("Calculating new result")
result = func(*args, **kwargs)
cache_store[func][key] = result
return result

return wrapper
2 changes: 1 addition & 1 deletion checklist.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Сheck Your Code Against the Following Points
v# Сheck Your Code Against the Following Points

## Code Efficiency

Expand Down
Loading