'Solution' #1496
'Solution' #1496
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets the task requirements and effectively handles caching for immutable arguments. While there are some suggestions for improvement, such as renaming variables for clarity and ensuring arguments are hashable, these are minor and don't impact the core functionality. Keep up the good work and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
|
|
||
| def cache(func: Callable) -> Callable: | ||
| # Write your code here | ||
| pass | ||
| tuple_data = {} |
There was a problem hiding this comment.
Consider renaming tuple_data to something more descriptive like cache_storage to better convey its purpose as a cache.
| tuple_data = {} | ||
|
|
||
| def inner(*args, **kwargs) -> Any: | ||
| num = (args,) |
There was a problem hiding this comment.
The variable num is used to store the arguments as a tuple. However, if args contains mutable objects, this could lead to issues since mutable objects are not hashable. Ensure that the arguments are hashable or consider using a different approach to handle caching for mutable arguments.
| num = (args,) | ||
| if num in tuple_data: | ||
| print("Getting from cache") | ||
| return tuple_data.get(num) |
There was a problem hiding this comment.
Using tuple_data.get(num) is correct, but you could also use tuple_data[num] since you have already checked for the key's existence in the dictionary.
No description provided.