Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

'Solution' #1496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
from typing import Callable
from typing import Callable, Any


def cache(func: Callable) -> Callable:
# Write your code here
pass
tuple_data = {}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming tuple_data to something more descriptive like cache_storage to better convey its purpose as a cache.

def inner(*args, **kwargs) -> Any:
num = (args,)
if num in tuple_data:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable num is used to store the arguments as a tuple. However, if args contains mutable objects, this could lead to issues since mutable objects are not hashable. Ensure that the arguments are hashable or consider using a different approach to handle caching for mutable arguments.

print("Getting from cache")
return tuple_data.get(num)
else:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using tuple_data.get(num) is correct, but you could also use tuple_data[num] since you have already checked for the key's existence in the dictionary.

result = func(*args, **kwargs)
tuple_data[num] = result
print("Calculating new result")
return result

return inner
Loading