Solution #752
Open
Solution #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiudmylaKulinchenko
suggested changes
Oct 2, 2023
app/main.py
Outdated
|
|
||
| cache_dict = {} | ||
|
|
||
| def wrapper(*args, **kwargs) -> None: |
app/main.py
Outdated
Comment on lines
21
to
28
| @cache | ||
| def long_time_func(arg1: int, arg2: int, arg3: int) -> int: | ||
| return (arg1 ** arg2 ** arg3) % (arg1 * arg3) | ||
|
|
||
|
|
||
| @cache | ||
| def long_time_func_2(n_tuple: tuple, power: int) -> int: | ||
| return [number ** power for number in n_tuple] |
app/main.py
Outdated
Comment on lines
15
to
17
| result = func(*args, **kwargs) | ||
| cache_dict[key] = result | ||
| return result |
There was a problem hiding this comment.
Avoid using additional variable here
LiudmylaKulinchenko
suggested changes
Oct 6, 2023
app/main.py
Outdated
| return wrapper | ||
|
|
||
|
|
||
| # I wrote a new function because I deleted the old one |
There was a problem hiding this comment.
You don't need these functions here. Remove tests from the main file, you already have tests for the decorator, they are in the different module. Don't mix tests and main logic
app/main.py
Outdated
| else: | ||
| print("Calculating new result") | ||
| cache_dict[key] = func(*args, **kwargs) | ||
| return cache_dict[key] |
There was a problem hiding this comment.
Move return out of condition so it won't be duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.