Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #752

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Solution #752

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f8449a
Solution
skoval7 Sep 30, 2023
5799249
Solution
skoval7 Sep 30, 2023
7294f9c
Solution3
skoval7 Oct 5, 2023
5ab8527
Solution4
skoval7 Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,28 @@
from typing import Callable
from typing import Callable, Any


def cache(func: Callable) -> Callable:
# Write your code here
pass

cache_dict = {}

def wrapper(*args, **kwargs) -> Any:
key = (args, frozenset(kwargs.items()))
if key in cache_dict:
print("Getting from cache")
return cache_dict[key]
else:
print("Calculating new result")
cache_dict[key] = func(*args, **kwargs)
return cache_dict[key]
return wrapper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move return out of condition so it won't be duplicated



# I wrote a new function because I deleted the old one
@cache
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need these functions here. Remove tests from the main file, you already have tests for the decorator, they are in the different module. Don't mix tests and main logic

def expensive_function(param1: int, param2: int) -> int:
return param1 + param2


@cache
def another_expensive_function(arg1: int, arg2: int, arg3: int) -> int:
return arg1 * arg2 * arg3
Loading