Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #756

Closed
wants to merge 3 commits into from
Closed

Solution #756

wants to merge 3 commits into from

Conversation

Wonsky1
Copy link

@Wonsky1 Wonsky1 commented Oct 1, 2023

Implemented cache decorator

app/main.py Outdated
print("Calculating new result")
result = func(*args)
cached_results[args] = result
return result
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to rewrite your decorator not to have return duplicated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsocie7y like the push i added last?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do i have to get rid of "else" block somehow, or it is fine?

Copy link

@fsocie7y fsocie7y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 🥇

@Wonsky1 Wonsky1 closed this by deleting the head repository Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants