Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #756

Closed
wants to merge 3 commits into from
Closed

Solution #756

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff7b056
Implemented cache decorator
Wonsky1 Oct 1, 2023
d6924bb
Rewrote code for better codestyle and readability
Wonsky1 Oct 1, 2023
164a4ee
Rewrote code without return duplicated
Wonsky1 Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,16 @@


def cache(func: Callable) -> Callable:
# Write your code here
pass
cached_results = {}

def inner(*args) -> int:
if args not in cached_results:
print("Calculating new result")
result = func(*args)
cached_results[args] = result
return result
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to rewrite your decorator not to have return duplicated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsocie7y like the push i added last?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do i have to get rid of "else" block somehow, or it is fine?


print("Getting from cache")
return cached_results.get(args)

return inner
Loading