Task done #769
Open
Task done #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Oct 9, 2023
app/main.py
Outdated
| # Write your code here | ||
| pass | ||
| def wrapper(*args) -> str: | ||
| func_name = f"{func}({args})" |
app/main.py
Outdated
| @@ -1,6 +1,19 @@ | |||
| from typing import Callable | |||
|
|
|||
|
|
|||
| cache_history = dict() | |||
There was a problem hiding this comment.
This variable must be inside decorator, to create separate state for each function
ArsenPidhoretskyi
suggested changes
Oct 9, 2023
app/main.py
Outdated
| def wrapper(*args) -> str: | ||
| # func_name = f"{func}({args})" | ||
|
|
||
| if f"{func}({args})" in cache_history: |
There was a problem hiding this comment.
Suggested change
| if f"{func}({args})" in cache_history: | |
| if args in cache_history: |
Why do you need func?
Remove it from all places
There was a problem hiding this comment.
I added the function name to the cache because I moved the cache to outside the decorator. In this case arguments could be repeated for different functions.
I corrected it as you recommended.
What else can I add to make the code better?
Yurnerroo
suggested changes
Oct 9, 2023
app/main.py
Outdated
| cache_history = dict() | ||
|
|
||
| def wrapper(*args) -> str: | ||
| # func_name = f"{func}({args})" |
app/main.py
Outdated
| pass | ||
| cache_history = dict() | ||
|
|
||
| def wrapper(*args) -> str: |
There was a problem hiding this comment.
Suggested change
| def wrapper(*args) -> str: | |
| def wrapper(*args) -> Any: |
Yurnerroo
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.