Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task done #769

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Task done #769

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d22c801
Task done
aleksandr-paslawski Oct 8, 2023
606626b
Changes made according to the recommendations
aleksandr-paslawski Oct 9, 2023
1ac2a7f
Changes made according to the recommendations
aleksandr-paslawski Oct 9, 2023
fb19ab4
Fixed code
aleksandr-paslawski Oct 9, 2023
45a7644
Сhanged type and delete comment
aleksandr-paslawski Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,17 @@


def cache(func: Callable) -> Callable:
# Write your code here
pass
cache_history = dict()

def wrapper(*args) -> str:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def wrapper(*args) -> str:
def wrapper(*args) -> Any:

# func_name = f"{func}({args})"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment


if f"{func}({args})" in cache_history:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if f"{func}({args})" in cache_history:
if args in cache_history:

Why do you need func?
Remove it from all places

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the function name to the cache because I moved the cache to outside the decorator. In this case arguments could be repeated for different functions.

I corrected it as you recommended.
What else can I add to make the code better?

print("Getting from cache")
else:
print("Calculating new result")
cache_history[f"{func}({args})"] = func(*args)

return cache_history[f"{func}({args})"]

return wrapper