-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'solution' #1614
base: master
Are you sure you want to change the base?
'solution' #1614
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
from app.people.customer import Customer | ||
|
||
|
||
class CinemaBar: | ||
@staticmethod | ||
def sell_product(product: str, customer: Customer) -> None: | ||
print(f"Cinema bar sold {product} to {customer.name}.") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
from app.people.cinema_staff import Cleaner | ||
|
||
|
||
class CinemaHall: | ||
|
||
def __init__(self, number: int) -> None: | ||
self.number = number | ||
|
||
def movie_session(self, | ||
movie_name: str, | ||
customers: list, | ||
cleaning_staff: Cleaner | ||
) -> None: | ||
print(f'"{movie_name}" started in hall number {self.number}.') | ||
|
||
for customer in customers: | ||
customer.watch_movie(movie_name) | ||
|
||
print(f'"{movie_name}" ended.') | ||
|
||
cleaning_staff.clean_hall(self.number) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,19 @@ | ||
# write your imports here | ||
from app.people.customer import Customer | ||
from app.people.cinema_staff import Cleaner | ||
from app.cinema.bar import CinemaBar | ||
from app.cinema.hall import CinemaHall | ||
|
||
|
||
def cinema_visit(customers: list, hall_number: int, cleaner: str, movie: str): | ||
# write you code here | ||
pass | ||
def cinema_visit(customers: list, | ||
hall_number: int, | ||
cleaner: str, | ||
movie: str) -> None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
customer_list = [Customer(customer["name"], customer["food"]) | ||
for customer in customers] | ||
cinema_hall = CinemaHall(hall_number) | ||
cleaner_person = Cleaner(cleaner) | ||
|
||
for customer in customer_list: | ||
CinemaBar.sell_product(customer.food, customer) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure that the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
cinema_hall.movie_session(movie, customer_list, cleaner_person) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
class Cleaner: | ||
def __init__(self, name: str) -> None: | ||
self.name = name | ||
|
||
def clean_hall(self, hall_number: int) -> None: | ||
print(f"Cleaner {self.name} is cleaning hall number {hall_number}.") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class Customer: | ||
def __init__(self, name: str, food: str) -> None: | ||
self.name = name | ||
self.food = food | ||
|
||
def watch_movie(self, movie_name: str) -> None: | ||
print(f'{self.name} is watching "{movie_name}".') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
cleaning_staff
parameter is being used as aCleaner
instance. This can lead to confusion and potential errors. It's important to use a different variable name for theCleaner
instance to maintain clarity and avoid overwriting the parameter. Consider renaming the parameter to something likecleaner
to avoid this issue.