Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'solution' #1614

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added app/cinema/__init__.py
Empty file.
7 changes: 7 additions & 0 deletions app/cinema/bar.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from app.people.customer import Customer


class CinemaBar:
@staticmethod
def sell_product(product: str, customer: Customer) -> None:
print(f"Cinema bar sold {product} to {customer.name}.")
21 changes: 21 additions & 0 deletions app/cinema/hall.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from app.people.cinema_staff import Cleaner


class CinemaHall:

def __init__(self, number: int) -> None:
self.number = number

def movie_session(self,
movie_name: str,
customers: list,
cleaning_staff: Cleaner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleaning_staff parameter is being used as a Cleaner instance. This can lead to confusion and potential errors. It's important to use a different variable name for the Cleaner instance to maintain clarity and avoid overwriting the parameter. Consider renaming the parameter to something like cleaner to avoid this issue.

) -> None:
print(f'"{movie_name}" started in hall number {self.number}.')

for customer in customers:
customer.watch_movie(movie_name)

print(f'"{movie_name}" ended.')

cleaning_staff.clean_hall(self.number)
21 changes: 17 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
# write your imports here
from app.people.customer import Customer
from app.people.cinema_staff import Cleaner
from app.cinema.bar import CinemaBar
from app.cinema.hall import CinemaHall


def cinema_visit(customers: list, hall_number: int, cleaner: str, movie: str):
# write you code here
pass
def cinema_visit(customers: list,
hall_number: int,
cleaner: str,
movie: str) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleaner parameter is being overwritten by a Cleaner instance on line 14. Consider using a different variable name for the Cleaner instance to avoid confusion and potential errors.

customer_list = [Customer(customer["name"], customer["food"])
for customer in customers]
cinema_hall = CinemaHall(hall_number)
cleaner_person = Cleaner(cleaner)

for customer in customer_list:
CinemaBar.sell_product(customer.food, customer)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the sell_product method of CinemaBar is used correctly as a static method. According to the task description, you should not create an instance of CinemaBar to call this method.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sell_product method of the CinemaBar class is correctly used as a static method here. Ensure that this usage is consistent throughout your codebase, as per the task requirements.

cinema_hall.movie_session(movie, customer_list, cleaner_person)
Empty file added app/people/__init__.py
Empty file.
6 changes: 6 additions & 0 deletions app/people/cinema_staff.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class Cleaner:
def __init__(self, name: str) -> None:
self.name = name

def clean_hall(self, hall_number: int) -> None:
print(f"Cleaner {self.name} is cleaning hall number {hall_number}.")
7 changes: 7 additions & 0 deletions app/people/customer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Customer:
def __init__(self, name: str, food: str) -> None:
self.name = name
self.food = food

def watch_movie(self, movie_name: str) -> None:
print(f'{self.name} is watching "{movie_name}".')
Loading