Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1642

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fe7edd
Solution
lozovoyDanil Dec 18, 2024
6705a86
Solution 2
lozovoyDanil Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,24 @@
class Person:
# write your code here
pass
people = {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The people dictionary is a class variable, which means it is shared across all instances of the Person class. This can lead to unexpected behavior when managing multiple Person instances. Consider moving the people dictionary to an instance variable by defining it within the __init__ method.


def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
Person.people[name] = self


def create_person_list(people: list) -> list:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The create_person_list function does not clear the people dictionary before adding new entries. This could lead to incorrect results if the function is called multiple times with different data. Make sure to clear the dictionary at the start of this function to ensure it only contains the current list of people.

# write your code here
pass
person_list = []

for person in people:
person_list.append(Person(person["name"], person["age"]))

for person in people:
current = Person.people[person["name"]]

if "wife" in person and person["wife"] is not None:
current.wife = Person.people[person["wife"]]
if "husband" in person and person["husband"] is not None:
current.husband = Person.people[person["husband"]]

return person_list
Loading