add files #1649
add files #1649
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this pull request! 😊 While your code meets most of the task requirements, there are a few critical issues that need to be addressed before we can approve it:
-
Error Handling for Non-existent References: When setting the 'wife' and 'husband' attributes, ensure that the referenced person exists in
Person.people. This will prevent potentialKeyErrorexceptions if the name is not found. Adding error handling for these cases is crucial to ensure the robustness of your code. -
Unique Names in
Person.people: Thepeopledictionary is used to store references toPersonobjects by their names. It's important to ensure that these names are unique to avoid overwriting existing entries, which could lead to incorrect relationships betweenPersonobjects.
Please address these issues to improve the functionality and reliability of your code. Once these changes are made, we can proceed with approving your pull request. Keep up the great work, and don't hesitate to reach out if you need any help! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| @@ -1,8 +1,25 @@ | |||
| class Person: | |||
| # write your code here | |||
| pass | |||
| people = {} | |||
There was a problem hiding this comment.
The people dictionary is used to store references to Person objects by their names. Ensure that names are unique to avoid overwriting existing entries.
| persons.append(person) | ||
|
|
||
| for person_data in people: | ||
| person = Person.people[person_data["name"]] |
There was a problem hiding this comment.
Accessing Person.people using person_data["name"] assumes that the name exists in the dictionary. Consider adding error handling to manage cases where the name might not be found.
| for person_data in people: | ||
| person = Person.people[person_data["name"]] | ||
| if "wife" in person_data and person_data["wife"]: | ||
| setattr(person, "wife", Person.people[person_data["wife"]]) |
There was a problem hiding this comment.
When setting the 'wife' attribute, ensure that the referenced person exists in Person.people. Otherwise, this could lead to a KeyError if the name is not found.
| if "wife" in person_data and person_data["wife"]: | ||
| setattr(person, "wife", Person.people[person_data["wife"]]) | ||
| if "husband" in person_data and person_data["husband"]: | ||
| setattr(person, "husband", Person.people[person_data["husband"]]) |
There was a problem hiding this comment.
Similar to the 'wife' attribute, ensure that the 'husband' attribute is set only if the referenced person exists in Person.people to avoid potential KeyError.
No description provided.