Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add files #1649

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,25 @@
class Person:
# write your code here
pass
people = {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The people dictionary is used to store references to Person objects by their names. Ensure that names are unique to avoid overwriting existing entries.


def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
Person.people[name] = self


def create_person_list(people: list) -> list:
# write your code here
pass
persons = []
for person_data in people:
name = person_data["name"]
age = person_data["age"]
person = Person(name, age)
persons.append(person)

for person_data in people:
person = Person.people[person_data["name"]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing Person.people using person_data["name"] assumes that the name exists in the dictionary. Consider adding error handling to manage cases where the name might not be found.

if "wife" in person_data and person_data["wife"]:
setattr(person, "wife", Person.people[person_data["wife"]])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When setting the 'wife' attribute, ensure that the referenced person exists in Person.people. Otherwise, this could lead to a KeyError if the name is not found.

if "husband" in person_data and person_data["husband"]:
setattr(person, "husband", Person.people[person_data["husband"]])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the 'wife' attribute, ensure that the 'husband' attribute is set only if the referenced person exists in Person.people to avoid potential KeyError.


return persons
Loading