Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done #1660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

done #1660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,25 @@
class Person:
# write your code here
pass

people = {}

def create_person_list(people: list) -> list:
# write your code here
pass
def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age

Person.people[name] = self


def create_person_list(people: list) -> list[Person]:
new_people_list = []

for human in people:
new_people_list.append(Person(human["name"], human["age"]))
Comment on lines +15 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using list comprehension to create the new_people_list. This will make the code more concise and is recommended by the checklist: 'When creating a list of instances from a collection (such as a list of dictionaries), it is recommended to use list comprehension rather than traditional for loops.'


for human in people:
if "wife" in human and human["wife"]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the dict.get() method instead of explicitly checking for the presence of a key. This approach simplifies the code and avoids potential KeyError exceptions, making it cleaner and more concise. For example: if human.get('wife'):

Person.people[human["name"]].wife = Person.people[human["wife"]]
elif "husband" in human and human["husband"]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, use the dict.get() method here instead of explicitly checking for the presence of a key. For example: elif human.get('husband'):

Person.people[human["name"]].husband = (
Person.people)[human["husband"]]

return new_people_list
Loading