Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1663

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1663

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c83735
Solution
kmalashchuk Dec 29, 2024
fdade9b
Solution
kmalashchuk Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,29 @@
class Person:
# write your code here
pass
people = {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a class-level dictionary people to store instances of Person can lead to issues if multiple instances of Person are created in different contexts or threads. Consider using an instance-level attribute or a different design pattern to manage Person instances.


def __init__(self, name, age):

def create_person_list(people: list) -> list:
# write your code here
pass
self.name = name
self.age = age
self.spouse = None
Person.people[name] = self

def __repr__(self):

spouse_info = f", Spouse: {self.spouse.name}" if self.spouse else ""
return f"Person(Name: {self.name}, Age: {self.age}{spouse_info})"


def create_person_list(people_data):
for person in people_data:
name = person["name"]
age = person["age"]
Person(name, age)

for person in people_data:
name = person["name"]
spouse_name = person.get("wife") or person.get("husband")
if spouse_name:
Person.people[name].spouse = Person.people.get(spouse_name)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code assumes that the spouse's name is unique and present in the people_data. If a spouse's name is not found in Person.people, this will result in a None value being assigned to spouse, which might not be the intended behavior. Consider adding error handling or validation to ensure that the spouse exists in the data.


return list(Person.people.values())
Loading