Develop #2697
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,78 @@ | ||
| import React, { useEffect, useState } from 'react'; | ||
| import { Todo } from '../../types/Todo'; | ||
| import { getTodos } from '../../api'; | ||
|
|
||
| type Props = { | ||
| setTodos: React.Dispatch<React.SetStateAction<Todo[] | null>>; | ||
| }; | ||
|
|
||
| export const TodoFilter: React.FC<Props> = ({ setTodos }) => { | ||
| const [qwerty, setQwerty] = useState(''); | ||
|
There was a problem hiding this comment. The variable name There was a problem hiding this comment. Consider renaming |
||
| const [status, setStatus] = useState(''); | ||
|
|
||
| useEffect(() => { | ||
| getTodos().then(serverTodos => { | ||
| let currentTodos: Todo[] | null = serverTodos.filter(todo => | ||
| todo.title.toLocaleLowerCase().includes(qwerty.toLocaleLowerCase()), | ||
| ); | ||
|
Comment on lines
+15
to
+17
There was a problem hiding this comment. Consider using optional chaining when accessing properties of potentially null or undefined objects, e.g., |
||
|
|
||
| switch (status) { | ||
| case 'active': | ||
| currentTodos = currentTodos.filter(todo => !todo.completed); | ||
| break; | ||
| case 'completed': | ||
| currentTodos = currentTodos.filter(todo => todo.completed); | ||
| break; | ||
| } | ||
|
|
||
| setTodos(currentTodos); | ||
| }); | ||
| }, [qwerty, status]); | ||
|
Check warning on line 30 in src/components/TodoFilter/TodoFilter.tsx
|
||
|
|
||
| return ( | ||
| <form className="field has-addons"> | ||
| <p className="control"> | ||
| <span className="select"> | ||
| <select | ||
| data-cy="statusSelect" | ||
| onChange={e => setStatus(e.target.value)} | ||
| > | ||
| <option value="all">All</option> | ||
| <option value="active">Active</option> | ||
| <option value="completed">Completed</option> | ||
| </select> | ||
| </span> | ||
| </p> | ||
|
|
||
| <p className="control is-expanded has-icons-left has-icons-right"> | ||
| <input | ||
| data-cy="searchInput" | ||
| type="text" | ||
| className="input" | ||
| placeholder="Search..." | ||
| value={qwerty} | ||
| onChange={e => { | ||
| setQwerty(e.target.value); | ||
| }} | ||
| /> | ||
| <span className="icon is-left"> | ||
| <i className="fas fa-magnifying-glass" /> | ||
| </span> | ||
|
|
||
| <span className="icon is-right" style={{ pointerEvents: 'all' }}> | ||
| {/* eslint-disable-next-line jsx-a11y/control-has-associated-label */} | ||
| {qwerty && ( | ||
| <button | ||
| data-cy="clearSearchButton" | ||
| type="button" | ||
| className="delete" | ||
| onClick={() => { | ||
| setQwerty(''); | ||
| }} | ||
| /> | ||
| )} | ||
| </span> | ||
| </p> | ||
| </form> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,100 +1,86 @@ | ||
| import React from 'react'; | ||
| import { Todo } from '../../types/Todo'; | ||
|
|
||
| type Props = { | ||
| todos: Todo[] | null; | ||
| setModalVisible: React.Dispatch<React.SetStateAction<boolean>>; | ||
| setSelectedTodo: React.Dispatch<React.SetStateAction<Todo | null>>; | ||
| selectedTodo: Todo | null; | ||
| }; | ||
|
|
||
| export const TodoList: React.FC<Props> = ({ | ||
| setModalVisible, | ||
| todos, | ||
| setSelectedTodo, | ||
| selectedTodo, | ||
| }) => { | ||
| // console.log(todos); | ||
|
|
||
| function mapTodos() { | ||
| return todos?.map(todo => ( | ||
| <tr | ||
| data-cy="todo" | ||
| className={ | ||
| selectedTodo?.id === todo.id ? 'has-background-info-light' : undefined | ||
| } | ||
| key={todo.id} | ||
| > | ||
| <td className="is-vcentered">{todo.id}</td> | ||
| <td className="is-vcentered"> | ||
| {todo.completed && ( | ||
| <span className="icon" data-cy="iconCompleted"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| )} | ||
| </td> | ||
| <td className="is-vcentered is-expanded"> | ||
| <p | ||
| className={todo.completed ? 'has-text-success' : 'has-text-danger'} | ||
| > | ||
| {todo.title} | ||
| </p> | ||
| </td> | ||
| <td className="has-text-right is-vcentered"> | ||
| <button | ||
| data-cy="selectButton" | ||
| className="button" | ||
| type="button" | ||
| onClick={() => { | ||
| setModalVisible(true); | ||
| setSelectedTodo(todo); | ||
| }} | ||
| > | ||
| <span className="icon"> | ||
| <i | ||
| className={ | ||
| selectedTodo && selectedTodo.id === todo.id | ||
| ? 'far fa-eye-slash' | ||
| : 'far fa-eye' | ||
| } | ||
| /> | ||
| </span> | ||
| </button> | ||
| </td> | ||
| </tr> | ||
| )); | ||
| } | ||
|
|
||
| return ( | ||
| <table className="table is-narrow is-fullwidth"> | ||
| <thead> | ||
| <tr> | ||
| <th>#</th> | ||
| <th> | ||
| <span className="icon"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| </th> | ||
| <th>Title</th> | ||
| <th> </th> | ||
| </tr> | ||
| </thead> | ||
|
|
||
| <tbody>{mapTodos()}</tbody> | ||
| </table> | ||
| ); | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
useEffecthook is set to run only once with an empty dependency array. Ensure this is the intended behavior, as it will not react to changes in any state or props.