-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MSC3531: Hiding messages during moderation #2041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a first pass there's mostly spec-related workflow concerns on this, but the change overall seems sensible. I've also left a review on the MSC itself which might ultimately impact the review of the actual visibility change code.
Apologies, I realized too late that I was missing a big part of the patch to handle redactions. Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this is looking fine - just a few more nitpicks, mostly around the project structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there :)
There's also MSC feedback which will need addressing ftr. Those aspects are not covered in code review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more step, and then we're there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, let's send it.
... after you fix merge conflicts and the build :D (try merging develop - should fix both, hopefully) |
(please don't force push onto reviewed branches - it invalidates review, thus making it required for re-review. In this case, the changes appear fine) |
Matrix-js-sdk-level support for hiding messages.
This is my first patch in matrix-js-sdk, please accept my apologies for anything I have done wrong.
MSC: matrix-org/matrix-spec-proposals#3531
Signed-off-by: David Teller [email protected]
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is, or addType: [enhancement/defect/task]
to the description and I'll add them for you.