Fix for request module after v2.16 dropped it #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteodanelli
requested changes
Aug 8, 2021
README.md
Outdated
| 1. Navigate into your MagicMirror's `modules` folder and execute `git clone https://github.com/matteodanelli/MMM-cryptocurrency.git`. | ||
| 2. Add the module inside `config.js` placing it where you prefer ;) | ||
| 1. Navigate into your MagicMirror's `modules` folder and execute `git clone https://github.com/theskyisthelimit/MMM-cryptocurrency.git`. | ||
| 2. Enter the Folder with `cd MMM-homeassistant-sensors` |
There was a problem hiding this comment.
what? it makes no sense.
It's not required to clone another package with a different folder just to create a package and add a request.
Weird.
I cannot accept this PR.
Please explain better the problem and your solution, if any.
Thanks.
|
With this commit a65658f I removed request. Is the issue in Docker still present? Are these changed really needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request solves the problem that with V2.16 of magicmirror the module request has been removed.
MagicMirrorOrg/MagicMirror#2617