Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for request module after v2.16 dropped it #93

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
14 changes: 12 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@


> The NPM module "Request" was removed with Magicmirror `v2.16` This has
> led to the fact that Magicmirror can no longer be started under
> Docker, for example. With this fork, the deprecated npm module
> "Request" is installed locally in the module's directory.


# MMM-cryptocurrency
A <a href="https://github.com/MichMich/MagicMirror">MagicMirror</a> module used to get real-time values of crypto currencies.

## Installation
1. Navigate into your MagicMirror's `modules` folder and execute `git clone https://github.com/matteodanelli/MMM-cryptocurrency.git`.
2. Add the module inside `config.js` placing it where you prefer ;)
1. Navigate into your MagicMirror's `modules` folder and execute `git clone https://github.com/theskyisthelimit/MMM-cryptocurrency.git`.
2. Enter the Folder with `cd MMM-homeassistant-sensors`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what? it makes no sense.
It's not required to clone another package with a different folder just to create a package and add a request.

Weird.
I cannot accept this PR.

Please explain better the problem and your solution, if any.
Thanks.

3. `npm init` and `npm install request`
4. Add the module inside `config.js` placing it where you prefer ;)


## Config
Expand Down
7 changes: 7 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "test",
"version": "0.1.0",
"dependencies": {
"request": "*"
}
}