-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
camera-server: Add ability to support taking image in video mode and video in image mode #349
Conversation
…photo in image mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't those go in the SetInformation
function above? Since it affects the CAMERA_INFORMATION message 🤔
Yeah I could put it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes sense. It would be nice if this came implicitly out of the camera subscriptions but I don't think there is an easy way to do so.
And thanks for the PR!
} | ||
|
||
message SupportVideoInImageModeRequest { | ||
bool support = 1; // True if the camera supports capturing video while in image mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool support = 1; // True if the camera supports capturing video while in image mode | |
bool is_supported = 1; // True if the camera supports capturing video while in image mode |
@@ -515,6 +521,20 @@ message RespondTrackingOffCommandResponse { | |||
CameraServerResult camera_server_result = 1; // The result of sending the response. | |||
} | |||
|
|||
message SupportImageInVideoModeRequest { | |||
bool support = 1; // True if the camera supports capturing images while in video mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool support = 1; // True if the camera supports capturing images while in video mode | |
bool is_supported = 1; // True if the camera supports capturing images while in video mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's easier and makes more sense.
PR associated with this change:
mavlink/MAVSDK#2351