Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camera-server: Add ability to support taking image in video mode and video in image mode #349

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

jnomikos
Copy link
Contributor

PR associated with this change:
mavlink/MAVSDK#2351

@jnomikos jnomikos changed the title camera-server: Add ability to support taking image in photo mode and photo in image mode camera-server: Add ability to support taking image in video mode and video in image mode Jul 13, 2024
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't those go in the SetInformation function above? Since it affects the CAMERA_INFORMATION message 🤔

@jnomikos
Copy link
Contributor Author

Couldn't those go in the SetInformation function above? Since it affects the CAMERA_INFORMATION message 🤔

Yeah I could put it in SetInformation. The reason I didn't was because it is probably rare for a user to want to set this. But I agree it makes more sense to be there.

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense. It would be nice if this came implicitly out of the camera subscriptions but I don't think there is an easy way to do so.

And thanks for the PR!

}

message SupportVideoInImageModeRequest {
bool support = 1; // True if the camera supports capturing video while in image mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool support = 1; // True if the camera supports capturing video while in image mode
bool is_supported = 1; // True if the camera supports capturing video while in image mode

@@ -515,6 +521,20 @@ message RespondTrackingOffCommandResponse {
CameraServerResult camera_server_result = 1; // The result of sending the response.
}

message SupportImageInVideoModeRequest {
bool support = 1; // True if the camera supports capturing images while in video mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool support = 1; // True if the camera supports capturing images while in video mode
bool is_supported = 1; // True if the camera supports capturing images while in video mode

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's easier and makes more sense.

@julianoes julianoes merged commit 517fef5 into mavlink:main Aug 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants