camera-server: Add ability to support taking image in video mode and video in image mode #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnomikos
changed the title
|
Looks like you have to rebase both the proto branch and this one and point to it again. |
Will do |
…photo in image mode Made image in video mode and video in image mode support definable in set_information
julianoes
force-pushed
the
photo_in_video
branch
from
c9777fa to
367bb40
Compare
|
I've merged the proto PR, and rebased (and squashed) everything here. Let's check CI and get it in. |
|
Thank you. Apologies for not doing it myself. Got distracted with other things |
JonasVautherin
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One limitation I ran into with camera-server was the inability to be able to set the capability flags for CAMERA_CAP_FLAGS_CAN_CAPTURE_IMAGE_IN_VIDEO_MODE and CAMERA_CAP_FLAGS_CAN_CAPTURE_VIDEO_IN_IMAGE_MODE. However, there are situations where a user may want to support this functionality. In an application I was working on, I wanted to be able to send these flags since the camera likely supported it.
This PR adds two new functions, support_image_in_video_mode and support_video_in_image_mode. A user can use these to enable the associated capability flags.
Please let me know if this is a good approach, or if there is a better way to support this functionality. Thank you!
(Proto PR: mavlink/MAVSDK-Proto#349)