core: consolidate component types #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakejahl
approved these changes
Oct 4, 2024
| provided */ | ||
| }; | ||
|
|
||
| } // namespace mavsdk |
There was a problem hiding this comment.
Hmmm. Why? clang-format doesn't seem to be concerned. Oh, yes it does. It didn't fix it because I ran it before commiting, so the new file wasn't on the git list yet.
There was a problem hiding this comment.
Fixed and force pushed.
| Gimbal, /** < @brief SDK is used as a gimbal. */ | ||
| Custom /**< @brief the SDK is used in a custom configuration, no automatic ID will be | ||
| provided */ | ||
| }; |
There was a problem hiding this comment.
I can make another PR to add RemoteId
There was a problem hiding this comment.
Yes, please make another one.
There was a problem hiding this comment.
I checked out this PR and added a commit on top. Once this is merged I'll rebase and push again.
I doesn't make sense to have this in two places, so I pulled it out.
julianoes
force-pushed
the
pr-consolidate-compoent-type
branch
from
ea2db2c to
22ec310
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I doesn't make sense to have this in two places, so I pulled it out.
What about this @dakejahl? Does that work for you?