feat(android.StopDetails): Shimmer loading #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
commented
Jan 9, 2025
| @@ -63,10 +63,10 @@ | |||
| <string name="other_link_source_code">Ver código fuente en GitHub</string> | |||
| <string name="other_link_tos">Términos de uso</string> | |||
| <string name="outbound">Saliente</string> | |||
| <string name="recently_viewed">Visto recientemente</string> | |||
There was a problem hiding this comment.
alphabetized in conflict resolution
KaylaBrady
force-pushed
the
kb-shimmer-load-2
branch
from
be3b6b4 to
a45e964
Compare
JackVCurtis
reviewed
Jan 10, 2025
| global: GlobalResponse?, | ||
| now: Instant, | ||
| filter: StopDetailsFilter?, | ||
| pinRoute: (String) -> Unit, | ||
| pinnedRoutes: Set<String>, | ||
| updateStopFilter: (StopDetailsFilter?) -> Unit | ||
| ) { | ||
| if (filter != null) { | ||
| if (departures == null) { |
There was a problem hiding this comment.
I think we could simplify this code by making the variables we need to change conditional on their own booleans, and having a single non-nested if statement. E.g.
val colModifier = if (departures == null) { Modifier.loadingShimmer() } else { Modifier }
val populatedPatternsByStop = if (departures == null) { LoadingPlaceholders.patternsByStop() } else { patternsByStop }
if (filter != null) {
Column(colModifier) {
StopDetailsRouteView(populatedPatternsByStop)
}
} else {
StopDetailsFilteredRouteView(populatedPatternsByStop)
}I find nested if statements tough to parse, personally.
There was a problem hiding this comment.
Point taken on readability! of neseted ifs! I opted to break out a distinct LoadingStopDetailsView in dd7e915 for consistency with LoadingRouteCard which also removes the nesting.
JackVCurtis
reviewed
Jan 10, 2025
| * Whether the sheet contents are loading. Used by low-level child views to determine whether they | ||
| * should be styled as placeholders by `Modifier.placeholderIfLoading()` | ||
| */ | ||
| val IsLoadingSheetContents = compositionLocalOf { false } |
JackVCurtis
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Nearby | Loading states
What is this PR for?
Follow up to #631
iOS
android
withContext(Dispatchers.Default)where possibleTesting
What testing have you done?
https://github.com/user-attachments/assets/622ce79c-8aa5-427f-adc2-61ec8b71b6dc