Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydrophones new type integration #582

Merged
merged 19 commits into from
Jun 18, 2024
Merged

Hydrophones new type integration #582

merged 19 commits into from
Jun 18, 2024

Conversation

frompotenza
Copy link
Contributor

There is also a PR in the sim repo

  • Once electrical figures out all the details (e.g., real frequency values, possible overflow problem), I can open another PR to change it. But for now, there are no errors

@antoinedang
Copy link
Contributor

@frompotenza I'm putting this as a draft PR, ping me on discord when u want me to review it / merge

@antoinedang antoinedang marked this pull request as draft June 17, 2024 23:47
@antoinedang antoinedang marked this pull request as ready for review June 18, 2024 00:21
@frompotenza
Copy link
Contributor Author

@antoinedang it's ready now

@antoinedang antoinedang merged commit fa3ed5c into noetic Jun 18, 2024
1 of 2 checks passed
@antoinedang antoinedang deleted the hydrophones branch June 18, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinedang antoinedang antoinedang approved these changes

@MrMondrian MrMondrian Awaiting requested review from MrMondrian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frompotenza @antoinedang