chore(ci): Labeler needs updating after Learn move #37294
Conversation
github-actions
bot
added
system
| @@ -19,27 +19,7 @@ Content:HTTP: | |||
| Content:JS: | |||
| - '\/docs\/Web\/JavaScript' | |||
| Content:Learn: | |||
There was a problem hiding this comment.
Not familiar with the new IA but do we not have these subareas anymore? It would still be helpful for domain-specific tutorials to be assigned to specific triagers/reviewers.
There was a problem hiding this comment.
Yeah I agree, I already started mapping these out in b328ad5 but I'm hesitant about it due to how much flux may happen here soon.
There was a problem hiding this comment.
Could you keep the other ones as comments or empty arrays? I want us to eventually use the exactly same set of labels unless you plan to remove or add entire areas,
There was a problem hiding this comment.
keep the [deleted] ones as comments or empty arrays
Good idea, I'll take a look at doing this
There was a problem hiding this comment.
On second thought, is there a reason why the labels can't describe the IA at the time being? Unless the migration will be done in a week, it would still be nice to have fine-grained triaging for all the different topics, especially for directing them to different maintainers. If we have to update this file again after the move anyway, it won't cause extra work.
There was a problem hiding this comment.
I like the idea of making the learn review assignments less granular; sure, it makes sense for domain experts to review the main MDN topic areas, but what is also important is the learn content having a consistent style, depth, and approach. This is something the coming updates will concentrate on quite a lot.
There was a problem hiding this comment.
I'm focusing on the Django and Express docs. They are currently almost exclusively reviewed by Hamish and I doubt the state will change much even if we remove the granularity. Sure I'd be glad for all core docs to be reviewed by the same group of people, but extension docs are topical in their nature that others may not find comfortable in reviewing.
Also I'm more comfortable with the reviewer pool being shared within the entire learning area. But labels should be applied as granularly as possible so to aid in searching, such as for old issues/PRs or looking for duplicates.
There was a problem hiding this comment.
Do you think we can merge this and get a follow-up for applying old labels? Currently we're missing Learn labels entirely, so I think a broader scope is okay until we have a solid idea what all subcategories should look like.
|
Could you update https://github.com/mdn/content/blob/main/.github/CODEOWNERS as well? |
.github/CODEOWNERS
Outdated
There was a problem hiding this comment.
Changes:
/files/en-us/learnpaths are removed- entries are alphabetical by path on file system
|
Thanks a lot, going to merge shortly |
Description
The content under
learn_web_developmentmay change over the coming weeks and months. While these changes are happening, it may be a good idea to make the matching a little more coarse for issues and PRs.Motivation
Issues and PRs do not get matched against the current
maindue to directory renaming.Related issues and pull requests