Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Labeler needs updating after Learn move #37294

Merged
merged 8 commits into from
Jan 28, 2025
Merged

chore(ci): Labeler needs updating after Learn move #37294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b06fa20
chore(ci): Update labeler following learn move, make matching coarser
bsmth Dec 20, 2024
b328ad5
chore(ci): Update labeler following learn move, make matching coarser
bsmth Dec 20, 2024
efc8181
chore(ci): Update labeler following learn move, make matching coarser
bsmth Dec 20, 2024
2ece8d5
Merge branch 'main' into labeler-rename
bsmth Jan 14, 2025
ff4610e
chore: restore deleted directory configs as comment
bsmth Jan 20, 2025
c176b51
chore: Remove learn from codeowners
bsmth Jan 27, 2025
cd02a23
Merge branch 'main' into labeler-rename
bsmth Jan 27, 2025
c693c16
Merge branch 'main' into labeler-rename
bsmth Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,41 +8,36 @@
# Default content owners
/files/en-us/ @mdn/yari-content-mdn

# MDN Firefox release notes
/files/en-us/mozilla/ @mdn/core-yari-content

# Mozilla Add-ons
/files/en-us/mozilla/add-ons/ @mdn/yari-content-mozilla-add-ons

# Accessibility
/files/en-us/web/accessibility/ @mdn/yari-content-accessibility
/files/en-us/learn/accessibility/ @mdn/yari-content-accessibility

# Web API
/files/en-us/web/api/ @mdn/yari-content-web-api

# CSS
/files/en-us/web/css/ @mdn/yari-content-css
/files/en-us/learn/css/ @mdn/yari-content-css

# HTML
/files/en-us/web/html/ @mdn/yari-content-html
/files/en-us/learn/html/ @mdn/yari-content-html

# JavaScript
/files/en-us/web/javascript/ @mdn/yari-content-javascript
/files/en-us/learn/javascript/ @mdn/yari-content-javascript

# HTTP
/files/en-us/web/http/ @mdn/yari-content-http
/files/en-us/learn/server-side/ @mdn/yari-content-http

# Web API
/files/en-us/web/api/ @mdn/yari-content-web-api

# Mozilla Add-ons
/files/en-us/mozilla/add-ons/ @mdn/yari-content-mozilla-add-ons
# JavaScript
/files/en-us/web/javascript/ @mdn/yari-content-javascript

# MathML
/files/en-us/web/mathml/ @mdn/content-mathml

# MDN Firefox Release Notes
/files/en-us/mozilla/firefox @mdn/core-yari-content

# New templates and sidebars
# Templates and sidebars (rari)
/files/jsondata/L10n-Template.json @mdn/core-dev
/files/sidebars @mdn/core-dev
/files/sidebars/ @mdn/core-dev

# ============================= CONTROL FILES ============================= #
# The CODEOWNERS file must end with these matches: Any pull request changing
Expand Down
44 changes: 23 additions & 21 deletions .github/issue-regex-labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,27 +19,29 @@ Content:HTTP:
Content:JS:
- '\/docs\/Web\/JavaScript'
Content:Learn:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the new IA but do we not have these subareas anymore? It would still be helpful for domain-specific tutorials to be assigned to specific triagers/reviewers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, I already started mapping these out in b328ad5 but I'm hesitant about it due to how much flux may happen here soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep the other ones as comments or empty arrays? I want us to eventually use the exactly same set of labels unless you plan to remove or add entire areas,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the [deleted] ones as comments or empty arrays

Good idea, I'll take a look at doing this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in ff4610e

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, is there a reason why the labels can't describe the IA at the time being? Unless the migration will be done in a week, it would still be nice to have fine-grained triaging for all the different topics, especially for directing them to different maintainers. If we have to update this file again after the move anyway, it won't cause extra work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of making the learn review assignments less granular; sure, it makes sense for domain experts to review the main MDN topic areas, but what is also important is the learn content having a consistent style, depth, and approach. This is something the coming updates will concentrate on quite a lot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm focusing on the Django and Express docs. They are currently almost exclusively reviewed by Hamish and I doubt the state will change much even if we remove the granularity. Sure I'd be glad for all core docs to be reviewed by the same group of people, but extension docs are topical in their nature that others may not find comfortable in reviewing.

Also I'm more comfortable with the reviewer pool being shared within the entire learning area. But labels should be applied as granularly as possible so to aid in searching, such as for old issues/PRs or looking for duplicates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can merge this and get a follow-up for applying old labels? Currently we're missing Learn labels entirely, so I think a broader scope is okay until we have a solid idea what all subcategories should look like.

- '\/docs\/Learn\/(Common|Front|Getting|Learning|Performance)'
Content:Learn:Accessibility:
- '\/docs\/Learn\/Accessibility'
Content:Learn:Client-side:
- '\/docs\/Learn\/Tools_and_testing\/(Client-side|Understanding_client-side)'
Content:Learn:Cross-Browser-Testing:
- '\/docs\/Learn\/Tools_and_testing\/Cross_browser_testing'
Content:Learn:CSS:
- '\/docs\/Learn\/CSS'
Content:Learn:Django:
- '\/docs\/Learn\/Server-side\/Django'
Content:Learn:Express:
- '\/docs\/Learn\/Server-side\/Express_Nodejs'
Content:Learn:Forms:
- '\/docs\/Learn\/Forms'
Content:Learn:GitHub:
- '\/docs\/Learn\/Tools_and_testing\/GitHub'
Content:Learn:HTML:
- '\/docs\/Learn\/HTML'
Content:Learn:JavaScript:
- '\/docs\/Learn\/JavaScript'
- '\/docs\/Learn_web_development\/'
# Mapping for old directories, see https://github.com/mdn/content/pull/36967
#
# Content:Learn:Accessibility:
# - '\/docs\/Learn\/Accessibility'
# Content:Learn:Client-side:
# - '\/docs\/Learn\/Tools_and_testing\/(Client-side|Understanding_client-side)'
# Content:Learn:Cross-Browser-Testing:
# - '\/docs\/Learn\/Tools_and_testing\/Cross_browser_testing'
# Content:Learn:CSS:
# - '\/docs\/Learn\/CSS'
# Content:Learn:Django:
# - '\/docs\/Learn\/Server-side\/Django'
# Content:Learn:Express:
# - '\/docs\/Learn\/Server-side\/Express_Nodejs'
# Content:Learn:Forms:
# - '\/docs\/Learn\/Forms'
# Content:Learn:GitHub:
# - '\/docs\/Learn\/Tools_and_testing\/GitHub'
# Content:Learn:HTML:
# - '\/docs\/Learn\/HTML'
# Content:Learn:JavaScript:
# - '\/docs\/Learn\/JavaScript'
Content:Manifest:
- '\/docs\/Web\/Manifest'
Content:MathML:
Expand Down
98 changes: 44 additions & 54 deletions .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,62 +57,53 @@ Content:JS:
Content:Learn:
- changed-files:
- all-globs-to-any-file:
- files/en-us/learn/**
- "!files/en-us/learn/accessibility/**"
- "!files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/**"
- "!files/en-us/learn/tools_and_testing/understanding_client-side_tools/**"
- "!files/en-us/learn/tools_and_testing/cross_browser_testing/**"
- "!files/en-us/learn/css/**"
- "!files/en-us/learn/server-side/django/**"
- "!files/en-us/learn/server-side/express_nodejs/**"
- "!files/en-us/learn/forms/**"
- "!files/en-us/learn/tools_and_testing/github/**"
- "!files/en-us/learn/html/**"
- "!files/en-us/learn/javascript/**"
- files/en-us/learn_web_development/**
- changed-files:
- any-glob-to-any-file:
- files/en-us/web/tutorials/**
Content:Learn:Accessibility:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/accessibility/**
Content:Learn:Client-side:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/**
- files/en-us/learn/tools_and_testing/understanding_client-side_tools/**
Content:Learn:Cross-Browser-Testing:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/tools_and_testing/cross_browser_testing/**
Content:Learn:CSS:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/css/**
Content:Learn:Django:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/server-side/django/**
Content:Learn:Express:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/server-side/express_nodejs/**
Content:Learn:Forms:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/forms/**
Content:Learn:GitHub:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/tools_and_testing/github/**
Content:Learn:HTML:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/html/**
Content:Learn:JavaScript:
- changed-files:
- any-glob-to-any-file:
- files/en-us/learn/javascript/**
# Mapping for old directories, see https://github.com/mdn/content/pull/36967
#
# Content:Learn:Accessibility:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/accessibility/**
# Content:Learn:Client-side:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/**
# - files/en-us/learn/tools_and_testing/understanding_client-side_tools/**
# Content:Learn:Cross-Browser-Testing:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/tools_and_testing/cross_browser_testing/**
# Content:Learn:CSS:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/css/**
# Content:Learn:Django:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/server-side/django/**
# Content:Learn:Express:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/server-side/express_nodejs/**
# Content:Learn:Forms:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/forms/**
# Content:Learn:GitHub:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/tools_and_testing/github/**
# Content:Learn:HTML:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/html/**
# Content:Learn:JavaScript:
# - changed-files:
# - any-glob-to-any-file:
# - files/en-us/learn/javascript/**
Content:Manifest:
- changed-files:
- any-glob-to-any-file:
Expand Down Expand Up @@ -170,7 +161,6 @@ Content:Other:
- changed-files:
- any-glob-to-any-file:
- files/en-us/related/**
- files/en-us/web/demos/**
- files/en-us/web/exslt/**
- files/en-us/web/opensearch/**
- files/en-us/web/privacy/**
Expand Down
Loading