Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to upload APKs to Play Store prevents APKs being published to GitHub #91

Closed
derickl opened this issue Aug 19, 2019 · 4 comments
Closed
Assignees
Labels
Type: Bug Fix something that isn't working as intended

Comments

@derickl
Copy link
Member

derickl commented Aug 19, 2019

After adding a new APK flavor (and tagging a release), upload to Play Store fails with the following error:

Google Api Error: applicationNotFound: No application was found for the given package name. - No application was found for the given package name

This likely points to the upload script expecting the app to have existed on the play store which is not the case for new flavours.

It would be best to delink publishing to GitHub from successfully uploading the APK to the play store.

@derickl derickl added the Type: Improvement Make something better label Aug 19, 2019
@garethbowen garethbowen added Type: Bug Fix something that isn't working as intended and removed Type: Improvement Make something better labels Feb 14, 2020
@garethbowen
Copy link
Member

This should just work, or we should at least document how to do it right the first time. Pushing to GH before trying Play Store sounds like a good idea so at least you get the apk with which to manually create the app.

@garethbowen
Copy link
Member

Delaying as there is a documented workaround.

@GopinathVempati
Copy link

Following are the steps followed to publish the app in playstore:
1.added new flavour in build.gradle file
2.selected the new flavour as build variant
3.added ' - fastlane deploy flavor:medic_new'
And finally generated app bundle to upload in playstore.
I didn't face any issue during the process.

@garethbowen garethbowen self-assigned this Dec 1, 2020
garethbowen added a commit that referenced this issue Dec 2, 2020
This means we can build all apks, and publish to GitHub, without
also publishing to the Play Store.

#138

Also solves a bug where Play Store rejection meant the apks weren't
uploaded to GitHub by switching the order of release steps.

#91
garethbowen added a commit that referenced this issue Dec 2, 2020
This means we can build all apks, and publish to GitHub, without
also publishing to the Play Store.

#138

Also solves a bug where Play Store rejection meant the apks weren't
uploaded to GitHub by switching the order of release steps.

#91
garethbowen added a commit that referenced this issue Dec 7, 2020
This means we can build all apks, and publish to GitHub, without
also publishing to the Play Store.

#138

Also solves a bug where Play Store rejection meant the apks weren't
uploaded to GitHub by switching the order of release steps.

#91
@garethbowen
Copy link
Member

garethbowen commented Dec 21, 2020

During the switch to GH Actions I fixed this by publishing the apks and not publishing to the Play Store. I raised an issue for reintroducing the Play Store publishing step and we'll ensure this happens after the apks are added to the release in GH so we don't regress here.

derickl pushed a commit that referenced this issue Jan 21, 2021
This means we can build all apks, and publish to GitHub, without
also publishing to the Play Store.

#138

Also solves a bug where Play Store rejection meant the apks weren't
uploaded to GitHub by switching the order of release steps.

#91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

3 participants