Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update focus group doc and add page to onboarding #1213

Merged
merged 12 commits into from
Oct 27, 2023
Merged

chore: update focus group doc and add page to onboarding #1213

merged 12 commits into from
Oct 27, 2023

Conversation

latin-panda
Copy link
Contributor

Description

  • Adds new page in the onboarding section to introduce all things related to Product Team, the idea is to move here some of the topics from All The Things document
  • Add resources related to Allies FG.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

andrablaj
andrablaj requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@andrablaj andrablaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @latin-panda for starting this page! I added a few comments, but nothing major.

content/en/contribute/medic/onboarding/product-team.md Outdated Show resolved Hide resolved
content/en/contribute/medic/onboarding/product-team.md Outdated Show resolved Hide resolved
content/en/contribute/medic/onboarding/product-team.md Outdated Show resolved Hide resolved
content/en/contribute/medic/onboarding/product-team.md Outdated Show resolved Hide resolved
content/en/contribute/medic/product-development-process/focused-groups.md Outdated Show resolved Hide resolved
andrablaj
andrablaj approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@andrablaj andrablaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions. Great job @latin-panda!

content/en/contribute/medic/onboarding/product-team.md Outdated Show resolved Hide resolved
content/en/contribute/medic/product-development-process/focused-groups.md Show resolved Hide resolved
@latin-panda
Copy link
Contributor Author

@mrjones-plip and @andrablaj, I've made all the changes to this PR, and it's ready for a final look.
I'll open a new PR for additional information and keep this one small.
Thanks for your time.

@andrablaj
Copy link
Member

@latin-panda, just noticed that @Phil-Mwago opened a related PR on the same page; maybe you can merge the updates into this PR? Not sure, up to you two.

@latin-panda latin-panda mentioned this pull request Oct 26, 2023
Closed
@latin-panda
Copy link
Contributor Author

Thanks @andrablaj! Good catch!
I've sent him a message to align both PRs :)

andrablaj
andrablaj approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@andrablaj andrablaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mrjones-plip
mrjones-plip approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@latin-panda
Copy link
Contributor Author

@Phil-Mwago I've added your description and followed your recommendation about not adding the number of developers but just keeping it plural in case there are more changes in the team.

I didn't add the Engineering Managers as formally part of the FG's team members, but happy to add it if that improve clarity cc: @andrablaj

@latin-panda latin-panda changed the title chore: focus group allies intro chore: update focus group doc and add page to onboarding Oct 27, 2023
Phil-Mwago
Phil-Mwago approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@Phil-Mwago Phil-Mwago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@latin-panda latin-panda merged commit a1d175e into main Oct 27, 2023
2 checks passed
@latin-panda latin-panda deleted the focus_group_allies_intro branch October 27, 2023 09:07
andrablaj
andrablaj reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@andrablaj andrablaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came here too late, but I want to flag the inconsistencies in the last commit. @latin-panda @Phil-Mwago

content/en/contribute/medic/product-development-process/focused-groups.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrablaj andrablaj andrablaj approved these changes

@Phil-Mwago Phil-Mwago Phil-Mwago approved these changes

@mrjones-plip mrjones-plip mrjones-plip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@latin-panda @andrablaj @mrjones-plip @Phil-Mwago