Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Fastify v5 #24

Merged

Conversation

jonnydgreen
Copy link

This comes with the following changes:

  • Support Fastify v5
  • Fix issue with the fastify content-type parser
  • Remove pnpm lock file and replace use of pnpm with npm in CI for consistency with other repos in this org
  • Bump Node.js support to 22.x+
  • Refactor the CI to ensure multiple os support and testing

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonnydgreen jonnydgreen merged commit 23cb241 into mercurius-js:master Oct 12, 2024
6 checks passed
@jonnydgreen jonnydgreen deleted the chore/support-fastify-v5 branch October 12, 2024 11:27
@capJavert
Copy link

capJavert commented Oct 28, 2024

This is still not released in 7.0.0. from what I see? We still get the same error from #23

Think it was pending release here #26 (comment)

Can this be released at some point?

@depo34
Copy link

depo34 commented Nov 12, 2024

Also hoping to get a hold of this from the npm package... will the v5 support be published there soon? Version 7.0.0 is still fastify v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants