Capture device debug content and log it #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d some comments to transformer to demystify protocol handling.
2 tasks
|
Build is failing due to version not being bumped, we really should have the versioning be done by the Action itself. |
|
@Hunter275 I did not want to be presumptuous about that but happy to do so if that is protocol... |
|
BTW, in the web client this seems to result in timeout errors logged for the heartbeart. I do not see these in the node serial version... Seems like there are some events sent to the radio that do not ever get the ack expected? |
We'll probably wrap several of your PRs (and others) into a single version bump so not necessary |
|
@Hunter275 yeah ok. seems right. I am eager to help, let me know what I can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101 - this captures the ascii text that comes between packets and logs it as a trace.
I also added some comments in to explain what the protocol handler is doing.