Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mypy typing #597

Closed

Conversation

william-stearns
Copy link
Contributor

Initial attempt to add python type hints to the majority of the (non pb2) python files in this repo. There are a few notes about things that may need attention, but it's largely focused on type hints.

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@william-stearns
Copy link
Contributor Author

I don't know how you'd like to see PRs generated. Please let me know if I need to do anything in another way to fit with your workflow.

@holdenweb
Copy link
Contributor

It appears the only thing that is currently holding up the PR (besides a committer with time to review it) is the non-existence of the BLEClient entity reference in ble_interface.py, line 121.

The annotation says you are trying to return an object of a non-existent class - just click on the "Details" links under "Some checks were not successful".

@william-stearns
Copy link
Contributor Author

Thank you so much, @holdenweb ! I hadn't realized the ball was back in my court.
I've removed the references to BLEClient typing, with the hope this is enough to get it going.

@william-stearns
Copy link
Contributor Author

I just went through github's "resolve conflicts". It appears this is ready again to be reviewed. Please let me know if something else is needed.

@ianmcorvidae
Copy link
Contributor

I'm sorry to have let this languish so long, completely lost track of it. I'm running the CI again which might pull up some issues, but other than those/fixing anything they uncover, this looks good. Thanks for the PR and your patience both!

If I lose track of it again, feel free to tag me in a comment to send another email, or ping me on discord if you're there (I'm mian, username m_ia_n, there).

@william-stearns
Copy link
Contributor Author

See #681 for a replacement for this PR that fixes the above CI errors.

@ianmcorvidae
Copy link
Contributor

That works, though pushing it to this same branch would also have been fine. I'll close this PR for now in favor of the other one though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants