Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variety of type annotations for mypy #681

Merged
merged 9 commits into from
Oct 29, 2024

Conversation

william-stearns
Copy link
Contributor

Replacing #597 (I'm sure there's a more elegant way to do this.) Fixes a single missing "import io" in stream_interface.py

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 85.10638% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.35%. Comparing base (0deb1d7) to head (384063d).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/ble_interface.py 43.75% 9 Missing ⚠️
meshtastic/stream_interface.py 70.00% 6 Missing ⚠️
meshtastic/util.py 94.00% 3 Missing ⚠️
meshtastic/__main__.py 90.00% 2 Missing ⚠️
meshtastic/tcp_interface.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage   60.37%   60.35%   -0.03%     
==========================================
  Files          24       24              
  Lines        3793     3811      +18     
==========================================
+ Hits         2290     2300      +10     
- Misses       1503     1511       +8     
Flag Coverage Δ
unittests 60.35% <85.10%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae
Copy link
Contributor

Hi @william-stearns -- I went through and fixed the rest of the mypy complaints locally and pushed that up here. Sorry about the back and forth on this and thanks again for contributing! I'll get this merged now that CI is happy.

@ianmcorvidae ianmcorvidae changed the title Wls add types2 Add a variety of type annotations for mypy Oct 29, 2024
@ianmcorvidae ianmcorvidae merged commit 9381acd into meshtastic:master Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants