Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc cmdInput1 and dependent(1) #75

Merged
merged 43 commits into from
Mar 14, 2022
Merged

doc cmdInput1 and dependent(1) #75

merged 43 commits into from
Mar 14, 2022

Conversation

wlammen
Copy link
Contributor

@wlammen wlammen commented Mar 3, 2022

fix description of cmdInput; improve that of cmdInput1 (version 1)

@wlammen wlammen changed the title doc cmdInput1 (1) doc cmdInput1 and dependent(1) Mar 3, 2022
@wlammen
Copy link
Contributor Author

wlammen commented Mar 4, 2022

I struggle with both doxygen features and invariants of metamath. Surprisingly (to me) the \a tag does not create a link, only (?) \ref does. Replaced the tag all over the place.
Then addToMemPool does not add a fully used block of memory to memUsedPool (in fact, it issues a bug message in this case), but pntrLet seems to be tolerant here. This is really confusing, and it forces me to adapt formerly written text accordingly.

@wlammen
Copy link
Contributor Author

wlammen commented Mar 6, 2022

The goal of this PR is reached. This is a good point to commit it.
(Only doc changes, code is left as is)
The next goal is print2

src/mmdata.c Outdated Show resolved Hide resolved
src/mmdata.c Outdated Show resolved Hide resolved
src/mmdata.c Outdated Show resolved Hide resolved
src/mmdata.c Outdated Show resolved Hide resolved
src/mmdata.c Outdated Show resolved Hide resolved
src/mmdata.h Show resolved Hide resolved
src/mmdata.h Outdated Show resolved Hide resolved
src/mminou.h Outdated Show resolved Hide resolved
src/mmdata.h Show resolved Hide resolved
src/mmvstr.h Outdated Show resolved Hide resolved
@wlammen
Copy link
Contributor Author

wlammen commented Mar 7, 2022

Thanks for the detailed review

src/mmdata.h Outdated Show resolved Hide resolved
src/mmvstr.h Outdated Show resolved Hide resolved
@wlammen
Copy link
Contributor Author

wlammen commented Mar 7, 2022

I just talked to an Ukrainian lady whose sister fled with her child from Kiev, leaving behind all her belongings and her husband. I am afraid I am mentally not capable of continuing here this evening. I wish you all the best, something others currently lack of.

@digama0 digama0 merged commit 8badce8 into metamath:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants