Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ plugins: Transition from Bundlr to Irys storage driver #533

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

JesseTheRobot
Copy link
Contributor

Context: Bundlr rebranded as Irys earlier today, and the GH org rename caused issues with users due to the AVSC git dependency the old version of the js-client being used.
To fix this, this PR transitions from a deprecated Bundlr js sdk version to the latest Irys SDK, and includes all relevant changes/renaming, including README & test changes.

Note: I wasn't able to figure out how to get most test cases to pass, I assume there's a testing endpoint I need to set up - but all the tests I was able to get working pass.

Transitions from a deprecated Bundlr js sdk version to the latest Irys SDK
@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: 496b73b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@metaplex-foundation/js Minor
@metaplex-foundation/js-plugin-aws Minor
@metaplex-foundation/js-plugin-nft-storage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@YvesCandel
Copy link

We're also experiencing the issue, so this would be great 👍

@JesseTheRobot
Copy link
Contributor Author

We're also experiencing the issue, so this would be great 👍

Hey @YvesCandel ,
A known fix in the meantime is to update/refresh lockfiles - I released a backported version with a fixed git repo URL, and the lockfile refresh seems to have worked for all the users having issues thusfar.

@justinkchen
Copy link

what is the fixed git repo URL supposed to be? I'm also getting this issue and when I did a pnpm up it didn't seem to fix the issue

@JesseTheRobot
Copy link
Contributor Author

@justinkchen
Copy link

i've tried pnpm up it still keeps the same package in the pnpm lockfile. any othre suggestions?

@JesseTheRobot
Copy link
Contributor Author

@justinkchen maybe uninstall/remove @metaplex-foundation/js (or whatever depends on it) and then reinstall it? that should remove it and re-add it to the lockfile

@justinkchen
Copy link

@JesseTheRobot that did it! thanks!

Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! I no longer have the rights to trigger CI but if it passes I think it's okay to merge. Note that here it's okay replace the Bundlr package (as opposed to in Umi) because here everything is bundled together so we want to avoid adding too many dependencies.

@jwcheon
Copy link

jwcheon commented Oct 24, 2023

facing the same issues, uninstall/install like @JesseTheRobot mentioned solves it for now

@JesseTheRobot
Copy link
Contributor Author

hey @lorisleiva , apologies for the inactivity on this PR as well.
I've updated the pnpm lock so that the CI can run without erroring - who do I need to talk to to get a re-run?

@lorisleiva
Copy link
Contributor

Thanks! Cc @febo would you mind just pressing the button to approve CI?

@JesseTheRobot
Copy link
Contributor Author

I'm not sure what I need to do here to fix the linting CI

@lorisleiva
Copy link
Contributor

pnpm lint:fix should do the trick.

@JesseTheRobot
Copy link
Contributor Author

I already ran that locally and it produced 0 changes - it looks like the pipeline errored trying to push to my branch, and the actual lint:fix ran without producing any changes.

@JesseTheRobot
Copy link
Contributor Author

@lorisleiva is there anything else I need to do here?

@lorisleiva
Copy link
Contributor

Hmm if it's just a linting issue I'm happy to merge it as-is. The main workflow will automatically create a fix commit when merged. I'm not at Metaplex anymore so I don't have the rights to merge but maybe @febo can do the honours?

@febo febo merged commit e484b77 into metaplex-foundation:main Nov 9, 2023
2 of 3 checks passed
@JesseTheRobot JesseTheRobot deleted the feat/bundlr-to-irys branch November 10, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants