feat(data catalog): add head routes #1875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
fast-data
Comment on lines
+201
to
+202
| | `/grpc.reflection.v1.ServerReflection` | `/grpc.reflection.v1.ServerReflection` | `control-plane` | `50051` | | ||
| | `/grpc.reflection.v1alpha.ServerReflection` | `/grpc.reflection.v1alpha.ServerReflection` | `control-plane` | `50051` | |
There was a problem hiding this comment.
is it correct to expose these endpoints?
There was a problem hiding this comment.
yes, they are needed to let control plane operator reach the control plane
| @@ -168,29 +168,6 @@ necessary to apply any further configuration. If in doubt, please contact your K | |||
| In case Control Plane service should be configured to be reachable from outside your cluster, for example because your Fast Data Control Plane application is located in a cluster | |||
| different from the one where Fast Data Runtimes are deployed, a few extra advanced configuration steps are necessary. These are listed here: | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| - **Introduce further Envoy [`cluster`](https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/cluster.proto) to expose the gRPC port of Control Plane service through the API Gateway.** | |
| This can be obtained by opening your Mia-Platform Console Project and selecting the Advanced tab from the Design area's sidebar. | |
| :::info | |
| This step is necessary if you are using Mia-Platform Console versions lower than v13.5.1. Otherwise, you can skip the modification to the file `api-gateway-envoy/clusters.yaml` here described. | |
| ::: | |
| Within this area of Console it is possible | |
| to extend Envoy API Gateway default configuration, by editing the file `api-gateway-envoy/clusters.yaml` with the following content: | |
| ```yaml title=api-gateway-envoy/clusters.yaml | |
| - "@type": type.googleapis.com/envoy.config.cluster.v3.Cluster | |
| name: control-plane | |
| connect_timeout: 30s | |
| http2_protocol_options: | |
| max_concurrent_streams: 100 | |
| type: LOGICAL_DNS | |
| lb_policy: ROUND_ROBIN | |
| load_assignment: | |
| cluster_name: control-plane | |
| endpoints: | |
| - lb_endpoints: | |
| - endpoint: | |
| address: | |
| socket_address: | |
| address: 'control-plane' | |
| port_value: 50051 |
Co-authored-by: Alberto Tessarotto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the documentation to include
HEADroutes for Control Plane and Data CatalogPull Request Type
PR Checklist
Other information