-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data catalog): add head routes #1875
Open
flower-of-the-bridges
wants to merge
6
commits into
main
Choose a base branch
from
feat(data-catalog)/add-head-routes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2200731
add: HEAD routes
flower-of-the-bridges e073964
fix: console communication bff snippets
flower-of-the-bridges 7f3392d
edit a doc link
albertotessarotto 671d3ed
added a note in CPO docs page
albertotessarotto ec154ea
removing obsolete note in projections page
albertotessarotto d823d4d
Update docs/data_catalog/data_catalog_fabric_bff.mdx
flower-of-the-bridges File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,29 +168,6 @@ necessary to apply any further configuration. If in doubt, please contact your K | |
In case Control Plane service should be configured to be reachable from outside your cluster, for example because your Fast Data Control Plane application is located in a cluster | ||
different from the one where Fast Data Runtimes are deployed, a few extra advanced configuration steps are necessary. These are listed here: | ||
|
||
- **Introduce further Envoy [`cluster`](https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/cluster.proto) to expose the gRPC port of Control Plane service through the API Gateway.** | ||
This can be obtained by opening your Mia-Platform Console Project and selecting the Advanced tab from the Design area's sidebar. Within this area of Console it is possible | ||
to extend Envoy API Gateway default configuration, by editing the file `api-gateway-envoy/clusters.yaml` with the following content: | ||
|
||
```yaml title=api-gateway-envoy/clusters.yaml | ||
- "@type": type.googleapis.com/envoy.config.cluster.v3.Cluster | ||
name: control-plane | ||
connect_timeout: 30s | ||
http2_protocol_options: | ||
max_concurrent_streams: 100 | ||
type: LOGICAL_DNS | ||
lb_policy: ROUND_ROBIN | ||
load_assignment: | ||
cluster_name: control-plane | ||
endpoints: | ||
- lb_endpoints: | ||
- endpoint: | ||
address: | ||
socket_address: | ||
address: 'control-plane' | ||
port_value: 50051 | ||
``` | ||
|
||
- **Expose new subdomain from which Control Plane gets accessible** (assuming [`traefik`](https://traefik.io/traefik/) is employed as ingress controller) | ||
In order to carry out this operation you first need to have access to the repository of the Console Project where Control Plane application has been configured. | ||
Within the project repository there is a folder named `overlays`, which should contains a folder for each environment available for the project. | ||
|
@@ -219,12 +196,14 @@ or via Fabric BFF. | |
In case the service must be reached from outside the cluster, the endpoints listed in the table below should be [defined in Console](/development_suite/api-console/api-design/endpoints.md) and assigned to Control Plane service. | ||
These endpoints are necessary to allow gRPC Control Plane Operator requests to reach Control Plane from outside the K8s cluster. | ||
|
||
| Endpoint | Rewrite Base Path | Microservice | | ||
|---------------------------------------------|---------------------------------------------|-----------------| | ||
| `/grpc.reflection.v1.ServerReflection` | `/grpc.reflection.v1.ServerReflection` | `control-plane` | | ||
| `/grpc.reflection.v1alpha.ServerReflection` | `/grpc.reflection.v1alpha.ServerReflection` | `control-plane` | | ||
| `/control_plane_fabric.RuntimeManagement` | `/control_plane_fabric.RuntimeManagement` | `control-plane` | | ||
| `/control_plane_fabric.ControlPlane` | `/control_plane_fabric.ControlPlane` | `control-plane` | | ||
| Endpoint | Rewrite Base Path | Microservice | Container Port | | ||
|---------------------------------------------|---------------------------------------------|-----------------|----------------| | ||
| `/grpc.reflection.v1.ServerReflection` | `/grpc.reflection.v1.ServerReflection` | `control-plane` | `50051` | | ||
| `/grpc.reflection.v1alpha.ServerReflection` | `/grpc.reflection.v1alpha.ServerReflection` | `control-plane` | `50051` | | ||
Comment on lines
+201
to
+202
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it correct to expose these endpoints? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, they are needed to let control plane operator reach the control plane |
||
| `/control_plane_fabric.RuntimeManagement` | `/control_plane_fabric.RuntimeManagement` | `control-plane` | `50051` | | ||
| `/control_plane_fabric.ControlPlane` | `/control_plane_fabric.ControlPlane` | `control-plane` | `50051` | | ||
|
||
Also, in the `Advanced Section` of each endpoint, be sure that the [Use DownStream Protocol option](/development_suite/api-console/api-design/endpoints.md#manage-advanced-endpoint-parameters) is set to `true`. | ||
|
||
### Routes | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.