Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve JSON parsing in pr-check script #46

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

The getNewPackages() function was incorrectly parsing JSON from git diff output, causing URL validation failures. This fix:

Testing:

  • Added unit tests for JSON parsing
  • Verified locally with pr-check script
  • Tested with existing valid packages

Copy link
Contributor

❌ No new packages found or validation failed.

Copy link
Contributor

✅ PR validation passed successfully!

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

@michaellatman michaellatman merged commit 8a9375f into main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant