Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable failing expired token test in CloudAdapter #4560

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

sw-joelmut
Copy link
Collaborator

#minor

Description

This PR disables the throws exception on expired token test due to invalid SigningKey value in the token. This will be skipped for now until a fix is provided, so it doesn't block new PR merges.

@sw-joelmut sw-joelmut requested a review from a team as a code owner November 8, 2023 13:59
@coveralls
Copy link

coveralls commented Nov 8, 2023

Pull Request Test Coverage Report for Build 6799263247

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.1%) to 84.633%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-core/src/cloudAdapterBase.ts 1 77.44%
libraries/botbuilder-core/src/configurationBotFrameworkAuthentication.ts 1 64.58%
libraries/botbuilder/src/cloudAdapter.ts 3 34.11%
libraries/botframework-connector/src/auth/allowedCallersClaimsValidator.ts 4 22.22%
libraries/botframework-connector/src/auth/parameterizedBotFrameworkAuthentication.ts 10 16.95%
Totals Coverage Status
Change from base Build 6733681775: -0.1%
Covered Lines: 20325
Relevant Lines: 22746

💛 - Coveralls

@sw-joelmut
Copy link
Collaborator Author

Hi @tracyboehrer

There is a unit test failing in main, preventing other PRs to pass. We created this PR to disable it temporarily until we provide a fix.

@tracyboehrer tracyboehrer merged commit 36fc0d0 into main Nov 8, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/skip-expired-token-test branch November 8, 2023 14:18
tracyboehrer pushed a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants