Move usermode halt logic into backing-specific logic #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
force-pushed
the
poll_apic-no-bool
branch
2 times, most recently
from
a217241 to
49925de
Compare
smalis-msft
force-pushed
the
poll_apic-no-bool
branch
from
aa1d38e to
d4ff8e9
Compare
sluck-msft
reviewed
Oct 23, 2024
Comment on lines
+684
to
+686
| if T::halt_in_usermode(self, GuestVtl::Vtl0) { | ||
| break Poll::Pending; | ||
| } else { |
There was a problem hiding this comment.
So for x64 the halt gets handled here, but in e.g. snp it gets handled in run_vp_snp? Do you know what the reasoning is for the difference in location? Wondering if we should try to be consistent.
There was a problem hiding this comment.
For x64 with apic emulation it gets handled here, which is only the case in test scenarios (WHP). For all other scenarios we call set_halted on the runner and let the kernel manage it for us, as that's more efficient.
There was a problem hiding this comment.
I'm not entirely familiar with why we can't do that for WHP, I just tried to preserve existing behavior here.
sluck-msft
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #111. Since WHP is the only case in which we can hit this path, make it a bit clearer with a new per-backing method. Open for bikeshedding of course