-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVM: refactor ohcl/ovmm emulator for flexible register retrieval and update #482
Conversation
Take a look at #478 too, lets make sure we don't conflict too hard. |
Overall this looks really nice, and a great step in the right direction. Thanks! |
@smalis-msft rebase done. could you kick off another CI run to make sure we're green? we're trying to get this in before the freeze, do you expect we'll need another reviewer? quick reminder, we cannot test ARM/AMD, so we'll need help on the MSFT side for that validation |
CI started, a little bit more feedback posted, and I'll get started on SNP testing. We don't need another reviewer. |
Also note that in order for this to get into 1.5 it will need to be cherry-picked to the release/2411 branch after merging, which may involve more merge conflicts. |
@smalis-msft really appreciate all of the detailed and speedy reviews, they have been incredibly helpful I think we should pass all CI gates after another run is kicked off, and tdx cvms are booting. anything else I should be doing to get this merged? |
LGTM! I still need to some more testing but if everything looks good on my end I'll merge it. |
Tested on SNP, everything looks good. |
Given that this change is focused solely on perf, and not functionality, I'm not sure it makes sense to deal with taking such a large change to 1.5. If it's really desired though you'll need to send up a PR with it cherry-picked onto release/2411. I can test SNP on that as well. |
Motivation
Changes
state
struct. Instead, the frontend calls functions to read and update register state.