-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flowey: use typestate pattern for gh variables #643
Merged
justus-camp-microsoft
merged 34 commits into
microsoft:main
from
justus-camp-microsoft:ghcontext_typestate
Jan 29, 2025
+285
−182
Merged
Changes from 18 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
f4f97df
try and get something working
justus-camp-microsoft 82db3d9
fmt
justus-camp-microsoft ff116bb
test printing pr event
justus-camp-microsoft 46a3016
plumb through is_object
justus-camp-microsoft 65fed09
Merge branch 'main' into ghcontext_typestate
justus-camp-microsoft dcfa810
try toJSON instead
justus-camp-microsoft 478329b
try echoing instead?
justus-camp-microsoft cbdd984
try another strategy
justus-camp-microsoft db8a9c9
add parentheses
justus-camp-microsoft c7f63cf
let's try jq
justus-camp-microsoft e360854
better typestate impl (still needs do_read de-dupe)
justus-camp-microsoft ebec5e1
plumb is_object through on write path
justus-camp-microsoft d55fc8a
add from_json
justus-camp-microsoft f778042
clippy
justus-camp-microsoft b71c81b
see what happens when the event doesn't exist
justus-camp-microsoft bfa2abd
remove unused events
justus-camp-microsoft ff200aa
remove from_json and add back test event
justus-camp-microsoft 1d8e3ff
move event to the right place
justus-camp-microsoft 06bade7
try another way of passing is_object through
justus-camp-microsoft 667fbb5
add comment about not adding further behavior to GhContextVar
justus-camp-microsoft 86f2354
Merge branch 'main' into ghcontext_typestate
justus-camp-microsoft 3aa18b6
move to separate module
justus-camp-microsoft d88b355
shared helper
justus-camp-microsoft a5b3562
clippy
justus-camp-microsoft 1cd416e
restructure modules, remove test event
justus-camp-microsoft c20f33a
move global vars to typestate without removing GhContextVar
justus-camp-microsoft 1395a24
remove ghcontextvar
justus-camp-microsoft 7abe491
submodule structure
justus-camp-microsoft 3f45028
re-introduce custom secrets flow
justus-camp-microsoft ac30808
Merge branch 'main' into ghcontext_typestate
justus-camp-microsoft 9f7afd1
comments
440251b
docs
a293393
doc tests
caca8e4
use ghvarstate for outputs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stale comment - not actually true with the introduction of
is_object