Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore setup_requires in setup.py #2124

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Oct 17, 2023

This got by accident removed here.

Since we are not (yet) using the isolated build system, we need to install setuptools_scm from the outside. If we would have used it, it would have picked up the build system dependencies from here.

setup.py Show resolved Hide resolved
@mxschmitt mxschmitt merged commit 59369fe into main Oct 17, 2023
1 of 3 checks passed
@mxschmitt mxschmitt deleted the restore_setuprequires branch October 17, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants