chore: move winldd to CDN #34078
Merged
chore: move winldd to CDN #34078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
move/winldd-to-cdn
branch
from
667732e to
75aaf0e
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Dec 19, 2024
yury-s
reviewed
Dec 19, 2024
| @@ -1315,6 +1315,8 @@ export async function installBrowsersForNpmInstall(browsers: string[]) { | |||
| return false; | |||
| } | |||
| const executables: Executable[] = []; | |||
| if (process.platform === 'win32') | |||
| executables.push(registry.findExecutable('winldd')!); | |||
There was a problem hiding this comment.
why do we have this for winldd but not for ffmpeg?
There was a problem hiding this comment.
This function is used for the browser-* packages which will install the browsers during the NPM install. We specify ffmpeg there every time on the caller side - we don't want to do that with winldd since its based on the process.platform so I moved it one layer deeper.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
move/winldd-to-cdn
branch
2 times, most recently
from
8da07c7 to
962e2f2
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
move/winldd-to-cdn
branch
from
962e2f2 to
1c6a9a1
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"6 flaky37391 passed, 650 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34071