Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][openimageio] Disable optional dependency jxl #42305

Merged

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Nov 22, 2024

Fix openimageio failed Undefined _BrotliEncoderCompressStream, https://dev.azure.com/vcpkg/public/_build/results?buildId=109536&view=results

Disabling the undeclared optional library jxl to fix.

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port installation tests pass with the following triplets:

  • arm64-osx
  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 22, 2024
@WangWeiLin-MV WangWeiLin-MV changed the title [pipeline][openimageio] Disable optional jxl [pipeline][openimageio] Disable optional dependency jxl Nov 22, 2024
@WangWeiLin-MV WangWeiLin-MV changed the title [pipeline][openimageio] Disable optional dependency jxl [vcpkg baseline][openimageio] Disable optional dependency jxl Nov 22, 2024
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review November 22, 2024 08:23
Cheney-W
Cheney-W previously approved these changes Nov 22, 2024
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Nov 22, 2024
@BillyONeal
Copy link
Member

I tried to merge this for you but I can't:

PS D:\vcpkg2> push-pr WangWeiLin-MV:ports/openimageio/disable-jxl  
Enumerating objects: 25, done.
Counting objects: 100% (25/25), done.
Delta compression using up to 24 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 927 bytes | 463.00 KiB/s, done.
Total 9 (delta 8), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (8/8), completed with 8 local objects.
remote: error: GH013: Repository rule violations found for refs/heads/ports/openimageio/disable-jxl.
remote: Review all repository rules at https://github.com/WangWeiLin-MV/vcpkg/rules?ref=refs%2Fheads%2Fports%2Fopenimageio%2Fdisable-jxl
remote:
remote: - Cannot update this protected ref.
remote:
remote: - This branch must not contain merge commits.
remote:   Found 1 violation:
remote:
remote:   7614ee16b530a0b20ffb76e3061855e7ce3cee74
remote:
To github.com:WangWeiLin-MV/vcpkg
 ! [remote rejected]     HEAD -> ports/openimageio/disable-jxl (push declined due to repository rule violations)

Please merge with master and we should be able to merge this. Thanks for the fix!

@BillyONeal BillyONeal marked this pull request as draft November 22, 2024 23:32
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review November 25, 2024 06:47
@BillyONeal BillyONeal merged commit 14dcbf1 into microsoft:master Nov 25, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the fix and the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants