Add extra guard clauses to deployment commands #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-azurecontainerapps into mwf/gentle-amber
nturinski
reviewed
Dec 26, 2024
| @@ -25,6 +26,13 @@ export async function deployContainerApp(context: IActionContext, node?: Contain | |||
| const subscriptionContext: ISubscriptionContext = createSubscriptionContext(item.subscription); | |||
| const subscriptionActionContext: ISubscriptionActionContext = { ...context, ...subscriptionContext }; | |||
|
|
|||
| if (item.containerApp.revisionsMode === KnownActiveRevisionsMode.Multiple) { | |||
| throw new Error(localize('multipleRevisionsNotSupported', 'The container app "{0}" cannot be updated using "Deploy to Container App..." while in multiple revisions mode.', item.containerApp.name)); | |||
There was a problem hiding this comment.
I think it'd be helpful to say how they can deploy it if not "Deploy to Container App." Same for the error below. I assume that you have to just right-click the specific revision or container depending on the scenario?
There was a problem hiding this comment.
Yeah good idea. I eventually would like to enable use of this command on the revisions directly, but I think that's a change for a future release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #773, #774
I think these guard clauses will improve reliability for the one click deploy commands.
Let me know if you disagree with having any of these guard clauses in place.
Update:
