-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra guard clauses to deployment commands #815
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
87841ca
Initial scaffold for deployContainerApp
MicroFish91 1088867
Improve wizard title
MicroFish91 3e85ad6
Add retries for failed updates
MicroFish91 e0a7003
Update throw condition
MicroFish91 c35bd08
Improve activity children and output logs
MicroFish91 ef87f0f
Add todo
MicroFish91 631be79
Add resource output logs
MicroFish91 b537741
Add comment
MicroFish91 146661f
Merge branch 'mwf/adorable-plum' of https://github.com/microsoft/vsco…
MicroFish91 e4ede57
Fix a log message
MicroFish91 7906366
Always prompt registry
MicroFish91 7c8d543
Improvements to finding recommended pick
MicroFish91 b8a81fb
Impl
MicroFish91 a5db872
Add fix for imageSourceListStep
MicroFish91 c9292be
Merge branch 'mwf/homely-emerald' of https://github.com/microsoft/vsc…
MicroFish91 1feaddd
Improve placeHolder prompt
MicroFish91 a139430
Fix deployImage
MicroFish91 f2cd6a7
Merge branch 'mwf/homely-emerald' of https://github.com/microsoft/vsc…
MicroFish91 300a5da
Merge with main
MicroFish91 2d05935
Improve acr pick recommendations
MicroFish91 209d1ac
Only sort if sr exists
MicroFish91 e2c87c6
Add draft boolean to context and register more children for editConta…
MicroFish91 7a8787c
Update editContainerImage
MicroFish91 eff6574
Improve comment
MicroFish91 5b22cc9
Improve comment again
MicroFish91 bd3e538
Add guard clauses to key commands
MicroFish91 57661f6
Small improvements
MicroFish91 d2eddbb
Make pick description search case insensitive
MicroFish91 4ec09bb
Change to pickUtils
MicroFish91 85eba7d
Consolidate with pickUtils
MicroFish91 85d8d1c
Merge branch 'mwf/fiscal-beige' of https://github.com/microsoft/vscod…
MicroFish91 ac5b4dc
Merge branch 'mwf/obliged-gold' of https://github.com/microsoft/vscod…
MicroFish91 6a98700
Feedback
MicroFish91 08428a0
Remove container app name
MicroFish91 1c709a0
Merge with main
MicroFish91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Add these error strings to the
const
file.