Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -preview in Dockerfile Scaffolding for .NET 8 RC release #4042

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Remove -preview in Dockerfile Scaffolding for .NET 8 RC release #4042

merged 2 commits into from
Sep 13, 2023

Conversation

alexyaang
Copy link
Member

@alexyaang alexyaang commented Aug 25, 2023 •
edited
Loading

Closes #4015

Don't merge until:

  • Test/validate Dockerfile when new .NET 8 image gets released

@alexyaang
Copy link
Member Author

Still not able to test it as mcr.microsoft.com/dotnet/aspnet:8.0 is not available yet.

@alexyaang
Copy link
Member Author

Tested on both windows and linux. Looks good.

@alexyaang alexyaang marked this pull request as ready for review September 13, 2023 14:07
@alexyaang alexyaang requested a review from a team as a code owner September 13, 2023 14:07
@alexyaang alexyaang merged commit 888c504 into main Sep 13, 2023
2 checks passed
@alexyaang alexyaang deleted the yangalex/netScaffolding branch September 13, 2023 14:07
@microsoft microsoft locked and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.NET: Change back from 8.0-preview to 8.0 tags
2 participants
@alexyaang @bwateratmsft