Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -preview in Dockerfile Scaffolding for .NET 8 RC release #4042

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Remove -preview in Dockerfile Scaffolding for .NET 8 RC release #4042

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec53c9
added new image convention for .NET 8 RC release
alexyaang Aug 25, 2023
aa11f61
added constant
alexyaang Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions src/scaffolding/wizard/netCore/NetCoreGatherInformationStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,14 @@ export class NetCoreGatherInformationStep extends GatherInformationStep<NetCoreS
wizardContext.netCoreRuntimeBaseImage = wizardContext.platform === '.NET: ASP.NET Core' ? `${aspNetBaseImage}:${netCoreVersion.major}.${netCoreVersion.minor}` : `${consoleNetBaseImage}:${netCoreVersion.major}.${netCoreVersion.minor}`;
wizardContext.netCoreSdkBaseImage = `${netSdkImage}:${netCoreVersion.major}.${netCoreVersion.minor}`;

if (netCoreVersion.major === 8) {
if (wizardContext.netCorePlatformOS === 'Windows') {
// append '-preview-nanoserver-ltsc2022' for windows base images for .NET 8's new naming convention
wizardContext.netCoreRuntimeBaseImage = `${wizardContext.netCoreRuntimeBaseImage}-preview-nanoserver-1809`;
wizardContext.netCoreSdkBaseImage = `${wizardContext.netCoreSdkBaseImage}-preview-nanoserver-1809`;
} else {
// append '-preview' for everything else
wizardContext.netCoreRuntimeBaseImage = `${wizardContext.netCoreRuntimeBaseImage}-preview`;
wizardContext.netCoreSdkBaseImage = `${wizardContext.netCoreSdkBaseImage}-preview`;
}
if (netCoreVersion.major === 9) {
bwateratmsft marked this conversation as resolved.
Show resolved Hide resolved
wizardContext.netCoreRuntimeBaseImage = `${wizardContext.netCoreRuntimeBaseImage}-preview`;
wizardContext.netCoreSdkBaseImage = `${wizardContext.netCoreSdkBaseImage}-preview`;
}
// append '-nanoserver-ltsc2022' for windows base images for .NET 8+'s new naming convention
if (wizardContext.netCorePlatformOS === 'Windows') {
wizardContext.netCoreRuntimeBaseImage = `${wizardContext.netCoreRuntimeBaseImage}-nanoserver-1809`;
bwateratmsft marked this conversation as resolved.
Show resolved Hide resolved
wizardContext.netCoreSdkBaseImage = `${wizardContext.netCoreSdkBaseImage}-nanoserver-1809`;
}

// change default user to adapt to Debian 12
Expand Down