Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IoT & Dialogue functionality #187

Merged
merged 495 commits into from
Aug 31, 2023
Merged

IoT & Dialogue functionality #187

merged 495 commits into from
Aug 31, 2023

Conversation

sultur
Copy link
Member

@sultur sultur commented Sep 22, 2022

Work in progress!

Integrating IoT and dialogue functionality into Greynir.

sultur and others added 30 commits July 6, 2022 16:52
… into the non-terminal functions instead of the answer funcs
console.log("result: ", result);
if (result.valid === true) {
console.log("Request url in valid check: ", requestURL);
window.location.href = `${requestURL}/iot-connect-success`;

Check warning

Code scanning / CodeQL

Client-side cross-site scripting

Cross-site scripting vulnerability due to [user-provided value](1).
return "Tenging við snjalltæki tókst";
} catch (error) {
console.log(error);
window.location.href = `${requestURL}/iot-connect-error`;

Check warning

Code scanning / CodeQL

Client-side cross-site scripting

Cross-site scripting vulnerability due to [user-provided value](1).
let connectButton = document.getElementById('connect_button');
connectButton.onclick = function () {
console.log('Click happened');
window.location.href = connectUrl;

Check warning

Code scanning / CodeQL

Client-side cross-site scripting

Cross-site scripting vulnerability due to [user-provided value](1).
const connectUrl = decodeURIComponent(queryParams.get('connect_url'));
let connectButton = document.getElementById('connect_button');
connectButton.onclick = function () {
window.location.href = connectUrl;

Check warning

Code scanning / CodeQL

Client-side cross-site scripting

Cross-site scripting vulnerability due to [user-provided value](1).
console.log("result: ", result);
if (result.valid === true) {
console.log("Request url in valid check: ", requestURL);
window.location.href = `${requestURL}/iot-connect-success`;

Check warning

Code scanning / CodeQL

Client-side URL redirect

Untrusted URL redirection due to [user-provided value](1).
return "Tenging við snjalltæki tókst";
} catch (error) {
console.log(error);
window.location.href = `${requestURL}/iot-connect-error`;

Check warning

Code scanning / CodeQL

Client-side URL redirect

Untrusted URL redirection due to [user-provided value](1).
let connectButton = document.getElementById('connect_button');
connectButton.onclick = function () {
console.log('Click happened');
window.location.href = connectUrl;

Check warning

Code scanning / CodeQL

Client-side URL redirect

Untrusted URL redirection due to [user-provided value](1).
const connectUrl = decodeURIComponent(queryParams.get('connect_url'));
let connectButton = document.getElementById('connect_button');
connectButton.onclick = function () {
window.location.href = connectUrl;

Check warning

Code scanning / CodeQL

Client-side URL redirect

Untrusted URL redirection due to [user-provided value](1).
Some refactoring to iot_hue and iot_speaker modules, simplified module grammars.
Improvements to grammar generator (now works around format strings).
Hotfix for small bug in dialogue.py, raised in query.py, will be fixed
better in coming commits to dialogue functionality.
Large modifications to Hue javascript, simplified the Hue grammar
for the time being. Working on Sonos module and the Sonos class.
Temporarily disabled spotify functionality (not as ready for
production). Currently refactoring the Sonos class.
@sultur sultur changed the base branch from master to iot_dialogue August 30, 2023 20:50
@sultur
Copy link
Member Author

sultur commented Aug 30, 2023

Changed target branch for this PR to iot_dialogue.
Next steps:

  1. Address merge conflicts quickly
  2. Merge PR into the branch (do we want to squash it? this is a lot of commits)
  3. Finish refactoring work there and, if possible, split the pull request into smaller ones

@KariSt1 KariSt1 marked this pull request as ready for review August 31, 2023 13:48
@sveinbjornt sveinbjornt merged commit 63b2bd6 into mideind:iot_dialogue Aug 31, 2023
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants