-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load collection stucks if compaction/gc happens #39701
fix: load collection stucks if compaction/gc happens #39701
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39701 +/- ##
===========================================
+ Coverage 69.39% 80.11% +10.72%
===========================================
Files 302 1480 +1178
Lines 27077 204864 +177787
===========================================
+ Hits 18790 164132 +145342
- Misses 8287 34861 +26574
- Partials 0 5871 +5871
|
rerun ut |
1 similar comment
rerun ut |
if compaction/gc happens, load collection may stuck due to SegmentNotFound, we should trigger UpdateNextTarget to get a new data view to execute loading operation. Signed-off-by: Wei Liu <[email protected]>
64ca787
to
e1616a9
Compare
@weiliu1031 go-sdk check failed, comment |
rerun go-sdk |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #39680 pr: #39701 if compaction/gc happens, load collection may stuck due to SegmentNotFound, we should trigger UpdateNextTarget to get a new data view to execute loading operation. Signed-off-by: Wei Liu <[email protected]>
Related to milvus-io#39701 & milvus-io#39681 Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io#39701 & milvus-io#39681 Signed-off-by: Congqi Xia <[email protected]>
Related to #39701 & #39681 Signed-off-by: Congqi Xia <[email protected]>
Cherry-pick from master pr: #39796 Related to #39701 & #39681 Signed-off-by: Congqi Xia <[email protected]>
issue: #39680 pr: #39701 if compaction/gc happens, load collection may stuck due to SegmentNotFound, we should trigger UpdateNextTarget to get a new data view to execute loading operation. Signed-off-by: Wei Liu <[email protected]>
Related to #39701 & #39681 Signed-off-by: Wei Liu <[email protected]>
Related to #39701 & #39681 Signed-off-by: Wei Liu <[email protected]>
issue: #39680
if compaction/gc happens, load collection may stuck due to SegmentNotFound, we should trigger UpdateNextTarget to get a new data view to execute loading operation.