Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load collection stucks if compaction/gc happens #39701

Conversation

weiliu1031
Copy link
Contributor

issue: #39680
if compaction/gc happens, load collection may stuck due to SegmentNotFound, we should trigger UpdateNextTarget to get a new data view to execute loading operation.

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. labels Feb 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 60.37736% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (d3e32bb) to head (e1616a9).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
tests/integration/util_collection.go 48.78% 16 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39701       +/-   ##
===========================================
+ Coverage   69.39%   80.11%   +10.72%     
===========================================
  Files         302     1480     +1178     
  Lines       27077   204864   +177787     
===========================================
+ Hits        18790   164132   +145342     
- Misses       8287    34861    +26574     
- Partials        0     5871     +5871     
Components Coverage Δ
Client 79.44% <ø> (∅)
Core 69.39% <ø> (ø)
Go 81.85% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/observers/target_observer.go 86.31% <100.00%> (ø)
internal/querycoordv2/task/scheduler.go 87.64% <100.00%> (ø)
tests/integration/util_collection.go 75.29% <48.78%> (ø)

... and 1175 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

rerun ut

1 similar comment
@weiliu1031
Copy link
Contributor Author

rerun ut

if compaction/gc happens, load collection may stuck due to
SegmentNotFound, we should trigger UpdateNextTarget to get a new data
view to execute loading operation.

Signed-off-by: Wei Liu <[email protected]>
Copy link
Contributor

mergify bot commented Feb 10, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Feb 11, 2025
@bigsheeper
Copy link
Contributor

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ff5c680 into milvus-io:master Feb 11, 2025
19 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Feb 11, 2025
issue: #39680
pr: #39701
if compaction/gc happens, load collection may stuck due to
SegmentNotFound, we should trigger UpdateNextTarget to get a new data
view to execute loading operation.

Signed-off-by: Wei Liu <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this pull request Feb 11, 2025
congqixia added a commit to congqixia/milvus that referenced this pull request Feb 11, 2025
sre-ci-robot pushed a commit that referenced this pull request Feb 11, 2025
sre-ci-robot pushed a commit that referenced this pull request Feb 11, 2025
Cherry-pick from master
pr: #39796
Related to #39701 & #39681

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Feb 11, 2025
issue: #39680
pr: #39701
if compaction/gc happens, load collection may stuck due to
SegmentNotFound, we should trigger UpdateNextTarget to get a new data
view to execute loading operation.

Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Feb 12, 2025
sre-ci-robot pushed a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants